gdbserial: fixes for rr 5.7.0 #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following fixes have been applied to make delve work with rr 5.7.0 - added a new launch prefix to exclude from stderr output - allow the thread selection packet to be sent for 'c' commands even when the stub supports thread suffixes, because the specification is unclear over what should be done with bc and bs packets with thread suffixes. - changed the way qRRCmd are escaped and added a thread selector to them to match changes to rr codebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fixes have been applied to make delve work with rr 5.7.0
added a new launch prefix to exclude from stderr output
allow the thread selection packet to be sent for 'c' commands even
when the stub supports thread suffixes, because the specification is
unclear over what should be done with bc and bs packets with thread
suffixes.
changed the way qRRCmd are escaped and added a thread selector to
them to match changes to rr codebase