Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/terminal: remove deprecated starlark global options #3722

Merged
merged 1 commit into from May 20, 2024
Merged

pkg/terminal: remove deprecated starlark global options #3722

merged 1 commit into from May 20, 2024

Conversation

alexandear
Copy link
Contributor

This PR removes usage of starlark global variable options, see google/starlark-go#435. Changes:

  • Remove resolve.AllowNestedDef, resolve.AllowLambda, resolve.AllowFloat, resolve.AllowBitwise because this obsolete flags has no effect.
  • Use starlark.ExecFileOptions instead of deprecated starlark.ExecFile.
  • Use starlark.EvalOptions instead of deprecated starlark.Eval.
  • Use starlark.EvalExprOptions instead of deprecated starlark.EvalExpr.

@alexandear alexandear force-pushed the pkg-terminal-starlark-resolve-deprecated branch from ab4599d to 32d7ff1 Compare May 10, 2024 11:32
aarzilli
aarzilli approved these changes May 11, 2024
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

derekparker
derekparker requested changes May 17, 2024
View reviewed changes
pkg/terminal/starbind/repl.go Outdated Show resolved Hide resolved
@alexandear alexandear force-pushed the pkg-terminal-starlark-resolve-deprecated branch from 32d7ff1 to 7dff5e1 Compare May 20, 2024 14:05
@alexandear alexandear force-pushed the pkg-terminal-starlark-resolve-deprecated branch from 7dff5e1 to db8c220 Compare May 20, 2024 14:06
derekparker
derekparker approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 468727c into go-delve:master May 20, 2024
2 checks passed
@alexandear alexandear deleted the pkg-terminal-starlark-resolve-deprecated branch May 20, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarzilli aarzilli aarzilli approved these changes

@derekparker derekparker derekparker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexandear @aarzilli @derekparker