Worktree.Commit: speed up commit with all: true option #139
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcuadros ca you please take a look here? |
|
Failed test doesn't seem to be connected to changes. |
mcuadros
approved these changes
Jul 21, 2020
mcuadros
changed the title
traidare
pushed a commit
to traidare/go-git
that referenced
this pull request
Oct 26, 2024
Worktree.Commit: speed up commit with all: true option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Partially fixes #113
Speeding up
worktree.Commit("message", &CommitOptions{All: true})due to invokingworktree.doAddFile(..)directly and avoid invokingworktree.Status()every time.In my case it speeds up commit from 70 sec to 2-5 seconds