Fix relative submodule resolution #195
Merged
+42
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the current behavior, the config will always hold the resolved, absolute URL, leavin the user of go-git no choice to determine whether the original URL is relative or not. This changes to employ relative URL resolution only when resolving a submodule to a repository to keep the correct configuration 'unresolved' and intact. Change relative resolution using `filepath.Dir` to `path.Join` while parsing both the 'root' and the relative URL with `net/url.URL`. Adapt test to verify the new behavior. Re-fixes go-git#184 (see comments).
valorl
added a commit
to valorl/argo-workflows
that referenced
this pull request
Nov 4, 2021
Upgrades src-d/go-git v4 to go-git/go-git v5.3.0. See go-git/go-git#195. Signed-off-by: valorl <11498571+valorl@users.noreply.github.com>
1 task
terrytangyuan
pushed a commit
to argoproj/argo-workflows
that referenced
this pull request
Nov 4, 2021
Upgrades src-d/go-git v4 to go-git/go-git v5.3.0. See go-git/go-git#195. Signed-off-by: valorl <11498571+valorl@users.noreply.github.com>
sarabala1979
pushed a commit
to argoproj/argo-workflows
that referenced
this pull request
Dec 15, 2021
Upgrades src-d/go-git v4 to go-git/go-git v5.3.0. See go-git/go-git#195. Signed-off-by: valorl <11498571+valorl@users.noreply.github.com>
traidare
pushed a commit
to traidare/go-git
that referenced
this pull request
Oct 26, 2024
Fix relative submodule resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current behavior, the config will always hold the resolved,
absolute URL, leavin the user of go-git no choice to determine whether
the original URL is relative or not.
This changes to employ relative URL resolution only when resolving
a submodule to a repository to keep the correct configuration
'unresolved' and intact.
Change relative resolution using
filepath.Dirtopath.Joinwhileparsing both the 'root' and the relative URL with
net/url.URL.Adapt test to verify the new behavior.
Re-fixes #184 (see comments).