Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotgit: fix a filesystem race in Refs/walkReferencesTree #659

Merged
merged 3 commits into from Mar 7, 2023

Commits on Jan 14, 2023

  1. dotgit: fix a filesystem race in Refs/walkReferencesTree

    In walkReferencesTree(), the filesystem is browsed recursively. After a folder
    is listed, each child element (directory, file) are inspected.
    
    What can happen is that by the time we get to operate on the child element, it
    might have been deleted from the filesystem and we would get a PathError.
    
    In the case of directories there was already a case to avoid bubbling up the error
    (we consider that there is no ref there, which is correct), but that was missing
    for files. This commit just apply the same logic.
    MichaelMure committed Jan 14, 2023
    Configuration menu
    Copy the full SHA
    cfec9e3 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. dotgit: test skip deleted references

    Checks that reading references it correctly skips deleted directories
    and files.
    
    Signed-off-by: Javi Fontan <jfontan@gmail.com>
    jfontan authored and MichaelMure committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    16cc293 View commit details
    Browse the repository at this point in the history
  2. dotgit: fix deleted references test in windows

    Signed-off-by: Javi Fontan <jfontan@gmail.com>
    jfontan authored and MichaelMure committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    660071d View commit details
    Browse the repository at this point in the history