Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Bump GitHub actions, enable go test race detection and stop using developer's GPG keys during test execution #701

Merged
merged 3 commits into from Mar 6, 2023
Merged

ci: Bump GitHub actions, enable go test race detection and stop using developer's GPG keys during test execution #701

merged 3 commits into from Mar 6, 2023

Commits on Mar 5, 2023

  1. tests: Avoid use of user's GPG keys during tests 

    The TestPullAdd test uses git CLI to perform a commit.
Contributors with signing enabled globally would have their GPG
configuration being used to sign that test commit.

This behaviour was transparent for contributors that do not use
secure keys which requires physical confirmation.
The new behaviour disables GPG signing for that test, which was
not required as part of the test.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
    @pjbgf
    pjbgf committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    fba136d View commit details
    Browse the repository at this point in the history

  2. ci: Bump GitHub actions 

    Removes the error messages:
  Node.js 12 actions are deprecated.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
    @pjbgf
    pjbgf committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    7368bb9 View commit details
    Browse the repository at this point in the history

  3. ci: Enable race detection for go tests 

    After the fix of data races in go-billy (go-git/go-billy/pull/28)
race detection can be enabled in go-git to ensure no new issues
go undetected.

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
    @pjbgf
    pjbgf committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    eddd209 View commit details
    Browse the repository at this point in the history