Add elastic 8 support via github.com/elastic/go-elasticsearch/v8
#30755
+423
−259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XL
github-actions
bot
added
modifies/go
|
Also update the action: gitea/.github/workflows/pull-db-tests.yml Line 95 in ad4e902 gitea/.github/workflows/pull-db-tests.yml Line 160 in ad4e902 |
|
elasticsearch 7 is still supported until 9.x is released. I think we should support both |
|
Ok, it's actually fine to test the minimum supported version. We do this for databases too. |
|
IIRC Additional work is required to maintain compatibility with these distros. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30752
From go-elasticsearch:
It's unclear how much compatibility it has with Elasticsearch v7 and v8. Maybe let the testing determine it