Restyle release list, fix branch dropdown #30837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
modifies/templates
wxiaoguang
reviewed
May 3, 2024
wxiaoguang
approved these changes
May 3, 2024
GiteaBot
added
lgtm/need 1
|
Sorry, I like the previous version better. I personally don't like too many frames. |
I think you will get used to it, it's pretty close to what github has now. |
lunny
approved these changes
May 3, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
removed
the
reviewed/wait-merge
Would you like to do it in this PR or defer it? I would prefer to do it together since this change is being tested. |
|
Yes I can do it here |
|
I prefer the previous version too. or at least the background color should be same. |
|
Maybe these boxes need a bit less color contrast against the page background. Would that work for you guys? |
|
Update my comment above: |
pull-request-size
bot
removed
the
size/M
pull-request-size
bot
added
the
size/L
|
@wxiaoguang renamed As for the design, I think the pro's outweight the cons and I find the previous design without a box looking dated. Imho we should "boxify" more things like the issue list in the future. |
silverwind
added
reviewed/wait-merge
silverwind
removed
the
reviewed/wait-merge
GiteaBot
added a commit
to GiteaBot/gitea
that referenced
this pull request
May 13, 2024
Fixes go-gitea#30821 and restyles the release list. Desktop: <img width="1199" alt="Screenshot 2024-05-02 at 20 46 10" src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd"> Mobile: <img width="443" alt="Screenshot 2024-05-02 at 20 46 21" src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d"> --------- Co-authored-by: Giteabot <teabot@gitea.io>
silverwind
added a commit
that referenced
this pull request
May 13, 2024
Backport #30837 by @silverwind Fixes #30821 and restyles the release list. Desktop: <img width="1199" alt="Screenshot 2024-05-02 at 20 46 10" src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd"> Mobile: <img width="443" alt="Screenshot 2024-05-02 at 20 46 21" src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d"> Co-authored-by: silverwind <me@silverwind.io>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 14, 2024
* giteaofficial/main: Protected tag is no internal server error (go-gitea#30962) [skip ci] Updated translations via Crowdin Restyle release list, fix branch dropdown (go-gitea#30837) fix: change npm scope registry (go-gitea#30964) Support using label names when changing issue labels (go-gitea#30943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30821 and restyles the release list.
Desktop:
Mobile: