New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: returns wrong error in transaction #45

Open

lonetrail wants to merge 1 commit into go-kratos:main from lonetrail:main

lonetrail commented Mar 12, 2024 •

edited

if _, e := u.cardRepo.CreateCard(ctx, id); err != nil {
	return e
}

Will always commit the transaction even CreateCard method is failed. It seems to be wrong.


          fix: returns wrong error in transaction

05b93be

dosubot bot added the size:XS label

shenqidebaozi approved these changes

View reviewed changes

dosubot bot added the lgtm label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment