Add control delete subtree for del hole OU #346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are keeping code in the root and in the v3 folder in sync. Can you make your changes in both places? |
|
Ok |
creater-xuwei
force-pushed
the
master
branch
from
40f64ff
to
1b18485
Compare
|
Is this PR stale? Any news on this, as I'm curently facing an issue where this control would come in handy // Edit: I implemented the control type in a fork. If the PR is stale and the creator doesn't respond I'll create a new one |
cpuschma
requested changes
Apr 12, 2022
| @@ -23,6 +23,8 @@ const ( | |||
|
|
|||
| // ControlTypeMicrosoftNotification - https://msdn.microsoft.com/en-us/library/aa366983(v=vs.85).aspx | |||
| ControlTypeMicrosoftNotification = "1.2.840.113556.1.4.528" | |||
| // ControlTypeSubtreeDelete - https://docs.microsoft.com/zh-cn/previous-versions/windows/desktop/ldap/ldap-server-tree-delete-oid | |||
There was a problem hiding this comment.
May you please use a english version as reference for this control type?
There was a problem hiding this comment.
I suggest you use: https://datatracker.ietf.org/doc/html/draft-armijo-ldap-treedelete-02
|
See #373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #345