Adding support for short form of ISO8601 #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Vincent <carlv@stripe.com>
Signed-off-by: Carl Vincent <carlv@stripe.com>
Signed-off-by: Carl Vincent <carlv@stripe.com>
youyuanwu
approved these changes
Apr 13, 2023
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
=======================================
Coverage 81.48% 81.48%
=======================================
Files 12 12
Lines 2031 2031
=======================================
Hits 1655 1655
Misses 297 297
Partials 79 79
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
casualjim
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working with an API that was giving me a date/time field that varies between ISO8601 long form (i.e. with a time value) and ISO8601 short (i.e. just the date) and kept getting this error:
turned out that the short form of ISO8601 was not implemented as one of the accepted formats for
strfmt.ParseDateTime(). This format is used in the example given for the native golang functiontime.ParseInLocation(), which in turn is the underlying function used to parse the time constants in this package.This PR adds this format, and modifies the subsequently related tests such that they all pass with the new modifications.