Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic .gitignore and update error messages and add new messages. #137

Closed
wants to merge 1 commit into from

Conversation

areese
Copy link
Contributor

@areese areese commented Feb 19, 2024

This pr adds a very basic .gitignore and adds error messages for move of the errors you can see out of the yubikeys.

Copy link
Collaborator

@ericchiang ericchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you actually hitting these errors? I would imagine that error messages like "Wrong parameters P1-P2" aren't very useful. At that point, should we just print the error code?

.gitignore Outdated Show resolved Hide resolved
@areese
Copy link
Contributor Author

areese commented Feb 20, 2024

Are you actually hitting these errors? I would imagine that error messages like "Wrong parameters P1-P2" aren't very useful. At that point, should we just print the error code?

I've hit them while building gpg support.
These errors go hand in hand with dumping the apdu's.

Most people won't hit them, but if you are adding things like attestation certs, or other functionality, you'll hit these a lot and they end up being more useful.

Add more apdu errors from the YubiCo specifications.
@areese areese mentioned this pull request Feb 20, 2024
@areese areese closed this Mar 7, 2024
@areese areese deleted the update-error-messages branch March 7, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants