-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baked in validators for containsfield and excludesfield #424
Add baked in validators for containsfield and excludesfield #424
Conversation
I considered making these validators panic on non-string types but it looks like that isn't the behavior of other validators so I decided against it. I also considered adding support for |
Hey @fharding1 thanks for the PR! I just have one request, can it be renamed to |
@joeybloggs thanks for the feedback, done. |
bump @joeybloggs |
sorry @fharding1 got sick after the holidays and now the family is sick, trying to catch up on all this, sorry for the delay |
No worries, I don't mean to be a bother, I just figured after a month you might have forgotten about it. Hope you and your family feels better soon! |
@fharding1 no worries, I do forget sometimes too ;) |
…round#424) * Add baked in validators for containsfield and excludesfield * Add ContainsAndExcludes test * Add NotEqual tests before AssertError * Add tests for missing fields * containsfield -> fieldcontains, excludesfield -> fieldexcludes
excludesfield is still on godoc https://godoc.org/github.com/go-playground/validator#hdr-Field_Excludes_Another_Field |
😔 excludesfield and containsfield is still on godoc, this keeps reporting errors. |
Change Details:
@go-playground/admins