Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes Japanese translation #433

Merged
merged 2 commits into from
Jan 9, 2019
Merged

Fixes Japanese translation #433

merged 2 commits into from
Jan 9, 2019

Conversation

akm
Copy link
Contributor

@akm akm commented Dec 21, 2018 •
edited

  • Tests exist or have been written that cover this particular change.

Change Details:

  • Use ja locale instead of en in ja_test.go
  • Comment out calling AddCardinal with locales.PluralRuleOne.
    • because cardinal plural rule 'One' does not exist for locale 'ja'.

@go-playground/admins

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 106b067 on akm:fix_ja_translation into 0277b12 on go-playground:v9.

@deankarn deankarn merged commit 9af2aa2 into go-playground:v9 Jan 9, 2019
fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
@fairyhunter13
Fixes Japanese translation (go-playground#433)
10f60db 
* Use ja locale instead of en in ja_test.go

* Comment out calling ut.AddCardinal with locales.PluralRuleOne

because cardinal plural rule 'One' does not exist for locale 'ja'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akm @coveralls @deankarn