Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email regex #463

Merged
merged 1 commit into from
Mar 31, 2019
Merged

Fix email regex #463

merged 1 commit into from
Mar 31, 2019

Conversation

benpaxton-hf
Copy link
Contributor

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Change Details:

  • Unescape a (?: in the email regex that shouldn't be escaped
  • Add a ) in the correct position to close the above
  • Add additional tests to verify correctness of email regex (both new tests fail with the old regex)

GitHub seems to not show the diff very nicely; the previously-escaped (?: is just before the second instance of x01 in the regex; the new ) is just before the @. git show <commit> --word-diff=color --word-diff-regex=. may help view this diff properly.

@go-playground/admins

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9099388 on benpaxton-hf:fix-email-regex into b199fa0 on go-playground:v9.

@deankarn
Copy link
Contributor

Thanks @benpaxton-hf for the PR, will try to look at it this week

@deankarn deankarn merged commit c0a5f73 into go-playground:v9 Mar 31, 2019
@benpaxton-hf benpaxton-hf deleted the fix-email-regex branch April 3, 2019 11:51
fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants