Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make required_without work with pointer #484

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Make required_without work with pointer #484

merged 1 commit into from
Jul 12, 2019

Conversation

leafduo
Copy link
Contributor

@leafduo leafduo commented Jun 13, 2019 •
edited

Fixes #483, #473 .

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Change Details:

  • Deal with pointers in requireCheckFieldKind

@go-playground/admins

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 54db112 on leafduo:v9 into 884d31b on go-playground:v9.

@deankarn
Copy link
Contributor

Thanks @leafduo ! will try to get to this soon

@deankarn deankarn merged commit d6546ee into go-playground:v9 Jul 12, 2019
@crathjen crathjen mentioned this pull request Jul 19, 2019
Closed
fairyhunter13 added a commit to fairyhunter13/validator that referenced this pull request Jul 12, 2020
@fairyhunter13
Merge pull request go-playground#484 from leafduo/v9
9a86785 
Make `required_without` work with pointer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

required_without does not work with pointers
3 participants
@leafduo @coveralls @deankarn