Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e.164 support #529

Merged
merged 1 commit into from
Dec 25, 2019
Merged

Add e.164 support #529

merged 1 commit into from
Dec 25, 2019

Conversation

taybart
Copy link
Contributor

@taybart taybart commented Oct 16, 2019 •
edited

Fixes Or Enhances # .
Add support for the E.164 format for phone numbers
Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Change Details:

  • Add E.164 support

@go-playground/admins

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0001%) to 99.883% when pulling aad1714 on taybart:v9 into cd1bd58 on go-playground:v9.

@farrukhny
Copy link

It will be helpful to adding this E.164 validation to v10 is there any plan to do that ?

@deankarn deankarn merged commit 17c1fa8 into go-playground:v9 Dec 25, 2019
@taybart
Copy link
Contributor Author

taybart commented Dec 25, 2019

Woohoo!

@deankarn
Copy link
Contributor

cherry picking into v10 also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taybart @coveralls @farrukhny @deankarn