New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation for custom functions #530

Merged

deankarn merged 2 commits into go-playground:v9 from skateinmars:chore/improve-doc

Dec 25, 2019

Contributor

skateinmars commented Oct 17, 2019

Make sure that you've checked the boxes below before you submit PR:

Tests exist or have been written that cover this particular change.

Change Details:

This PR tries to improve documentation around custom functions and manual validations.

The first commit reworks the non standard fields documentation to try and make it clearer how to use NonBlank.
The second commit clarifies the examples around Namespace() and Field(). I believe the current usage of ReportError in the example was not intended, but I may be totally wrong here!

@go-playground/admins

skateinmars added 2 commits

October 17, 2019 19:41


          Rework the non standard validators documentation

94aa424


          Clarify and complete tag names example

c370ccf

coveralls commented Oct 17, 2019

Coverage remained the same at 99.883% when pulling c370ccf on skateinmars:chore/improve-doc into cd1bd58 on go-playground:v9.

deankarn merged commit 5bbca66 into go-playground:v9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment