Improves accuracy of datauri regex #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Or Enhances go-playground#518. Make sure that you've checked the boxes below before you submit PR: [x] Tests exist or have been written that cover this particular change. Change Details: The datauri validation was not allowing certain valid strings; this commit updates the regex to meet RFC 2397. I drew heavily on this gist https://gist.github.com/khanzadimahdi/bab8a3416bdb764b9eda5b38b35735b8, but had to make a few updates to remove some negative lookaheads (which Go doesn't allow afaik), and to account for the way the `isDataURI` function works - it validates the base64 separately from the other parts of the uri. @go-playground/admins
1 task
fairyhunter13
added a commit
to fairyhunter13/validator
that referenced
this pull request
Jul 12, 2020
Improves accuracy of datauri regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances #518.
Make sure that you've checked the boxes below before you submit PR:
[x] Tests exist or have been written that cover this particular change.
Change Details:
The datauri validation was not allowing certain valid strings; this
commit updates the regex to meet RFC 2397. I drew heavily on this gist
https://gist.github.com/khanzadimahdi/bab8a3416bdb764b9eda5b38b35735b8,
but had to make a few updates to remove some negative lookaheads (which
Go doesn't allow afaik), and to account for the way the
isDataURIfunction works - it validates the base64 separately from the other parts
of the uri.
@go-playground/admins