Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow numbers in FQDN validation #612

Merged
merged 4 commits into from
May 21, 2020
Merged

Allow numbers in FQDN validation #612

merged 4 commits into from
May 21, 2020

Conversation

Giulianos
Copy link
Contributor

Fixes FQDN validation to allow numerical subdomains/hosts #602

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

Change Details:

  • Add regex based on hostname RFC1123 adding check for existence of TLD.
  • Update isFQDN removing checks already done by regex

@go-playground/admins

@deankarn deankarn merged commit 059510c into go-playground:master May 21, 2020
@Giulianos Giulianos deleted the bugfix/fqdn branch May 21, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Giulianos @deankarn