Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept 0x(0X) start in 'hexadecimal' tag #620

Merged
merged 2 commits into from Sep 27, 2020
Merged

accept 0x(0X) start in 'hexadecimal' tag #620

merged 2 commits into from Sep 27, 2020

Conversation

leejh903
Copy link
Contributor

@leejh903 leejh903 commented Jun 4, 2020

Enhances

Make sure that you've checked the boxes below before you submit PR:

  • [v] Tests exist or have been written that cover this particular change.

Change Details:
Changed hexadecimalRegexString regex to support 0x(0X) start

  • hexadecimal usually uses 0x(0X) prefix to avoid confusion with decimal, octal or other numbering systems
  • It accepts 0x(0X) prefix optionally. It means if there is not the prefix, It is ok

@go-playground/admins

@deankarn deankarn merged commit 704a814 into go-playground:master Sep 27, 2020
@renovate renovate bot mentioned this pull request May 28, 2021
Closed
This was referenced Jun 6, 2021
Closed
Open
Closed
@renovate renovate bot mentioned this pull request Jun 24, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elias19r elias19r elias19r approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leejh903 @elias19r @deankarn