Add support for excluded_with on pointer fields #746
Merged
+95
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10352,9 +10417,10 @@ func TestExcludedWithoutAll(t *testing.T) { | |||
| Field2 *string `validate:"excluded_without_all=Field FieldE" json:"field_2"` | |||
| Field3 map[string]string `validate:"excluded_without_all=Field FieldE" json:"field_3"` | |||
| Field4 interface{} `validate:"excluded_without_all=Field FieldE" json:"field_4"` | |||
| Field5 string `validate:"excluded_without_all=Inner.Field Inner.Field2" json:"field_5"` | |||
| Field5 string `validate:"excluded_without_all=Inner.Field Inner2.Field" json:"field_5"` | |||
There was a problem hiding this comment.
This seemed like a typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Closes #745
Using a tag like
excluded_withwill now work as expected on pointer fields (e.g.*string). There are two commits here. The first commit adds in tests (which fail) to demonstrate the behavior that was missing. The second commit improves the code so that the tests pass.I checked to see if this would also address this comment about struct pointers, but it does not.
Make sure that you've checked the boxes below before you submit PR:
@go-playground/admins