Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iso-3166-2 #788

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Add iso-3166-2 #788

merged 4 commits into from
Jul 8, 2021

Conversation

erma07
Copy link
Contributor

@erma07 erma07 commented Jun 27, 2021

Fixes Or Enhances

Adds the option to validate iso-3166-2 codes

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@erma07
Update country_codes.go
31c2bf4 
add iso3166_2 codes
@erma07
Update baked_in.go
38090ad 
Add iso3166_2 check with isIso31662 function
@erma07
Update validator_test.go
f8abaf0 
Add iso3166_2 test
@coveralls
Copy link

coveralls commented Jun 27, 2021 •
edited

Coverage Status

Coverage increased (+0.008%) to 75.965% when pulling 1a1c270 on erma07:master into 8bfa88a on go-playground:master.

@erma07
Copy link
Contributor Author

erma07 commented Jun 27, 2021

Ubuntu 18.04.5 LTS /usr/share/iso-codes/json/iso_3166-2.json is the source of the iso_3166-2 map

@erma07
Copy link
Contributor Author

erma07 commented Jul 1, 2021

Is it possible to merge this change because I really need it in my service?

@deankarn deankarn merged commit af8b8d1 into go-playground:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deankarn deankarn deankarn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erma07 @coveralls @deankarn