Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement github workflow events (Dispatch, Job, Run) #139

Merged
merged 1 commit into from Nov 16, 2021

Conversation

dvonthenen
Copy link
Contributor

@coveralls
Copy link

coveralls commented Oct 25, 2021

Coverage Status

Coverage increased (+0.2%) to 88.136% when pulling ffc40ad on dvonthenen:feature/workflowjob into 3c38273 on go-playground:master.

@dvonthenen dvonthenen marked this pull request as draft October 25, 2021 22:51
@dvonthenen dvonthenen force-pushed the feature/workflowjob branch 5 times, most recently from 7687e8d to 2ba9f6e Compare October 26, 2021 17:18
@dvonthenen
Copy link
Contributor Author

Ok, this is hopefully ready for review now that I added in the go test and sample data.

@dvonthenen dvonthenen marked this pull request as ready for review October 26, 2021 17:20
Copy link
Contributor

@tohjustin tohjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this PR! Would also like to see support for GitHub workflow events in this package.

github/github.go Outdated Show resolved Hide resolved
Co-authored-by: Justin Toh <tohjustin@hotmail.com>
@dvonthenen
Copy link
Contributor Author

dvonthenen commented Nov 15, 2021

Thanks for creating this PR! Would also like to see support for GitHub workflow events in this package.

Not sure what you mean... could you point me out to where these events are in the code base? I'm fairly new to the GitHub webhook stuff.

@tohjustin
Copy link
Contributor

Thanks for creating this PR! Would also like to see support for GitHub workflow events in this package.

Not sure what you mean... could you point me out to where these events are in the code base? I'm fairly new to the GitHub webhook stuff.

Sorry, I meant to say that I would like to see your changes in this PR merged. (I believe you have already implemented all the workflow-based webhook events that GitHub supports) 😄

@deankarn @Toshik1978 By any chance either of you are free this week to review this? Thank you 🙏🏼

@dvonthenen
Copy link
Contributor Author

Ahhhhh ok... I thought it was something I was missing or something.

@Toshik1978 Toshik1978 merged commit 9c954e2 into go-playground:master Nov 16, 2021
@tohjustin
Copy link
Contributor

Thanks @dvonthenen & @Toshik1978!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants