Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mysqlx. #147

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add mysqlx. #147

wants to merge 1 commit into from

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Feb 11, 2018

No description provided.

@AlekSi AlekSi added the feature label Feb 11, 2018
@AlekSi AlekSi added this to the v1.4.0 milestone Feb 11, 2018
@codecov
Copy link

codecov bot commented Feb 11, 2018 •
edited

Codecov Report

Merging #147 into v1-stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           v1-stable    #147   +/-   ##
=========================================
  Coverage       68.4%   68.4%           
=========================================
  Files             19      19           
  Lines           1557    1557           
=========================================
  Hits            1065    1065           
  Misses           442     442           
  Partials          50      50
Impacted Files Coverage Δ
reform-db/main.go 1.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8019070...3e03e6f. Read the comment docs.

@AlekSi AlekSi modified the milestone: v1.4.0 Apr 16, 2018
AlekSi
AlekSi commented Apr 16, 2018
View reviewed changes
reform-db/cmd_query.go Outdated
queryFlags.PrintDefaults()

// TODO mention -split flag
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be documented.

AlekSi
AlekSi commented Apr 16, 2018
View reviewed changes
reform-db/cmd_exec.go Outdated
execFlags.PrintDefaults()

// TODO mention -split flag
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be documented.

@AlekSi AlekSi closed this Dec 28, 2018
@AlekSi AlekSi changed the base branch from v1-4 to v1-stable December 28, 2018 07:15
@AlekSi AlekSi reopened this Dec 28, 2018
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #147 into v1-stable will increase coverage by 8.62%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           v1-stable     #147      +/-   ##
=============================================
+ Coverage      59.87%   68.49%   +8.62%     
=============================================
  Files             19       19              
  Lines           1565     1565              
=============================================
+ Hits             937     1072     +135     
+ Misses           580      443     -137     
- Partials          48       50       +2
Impacted Files Coverage Δ
reform-db/main.go 1.2% <ø> (ø) ⬆️
querier_selects.go 97.39% <0%> (+2.6%) ⬆️
querier_commands.go 81.73% <0%> (+3.71%) ⬆️
reform-db/cmd_init.go 69.41% <0%> (+8.82%) ⬆️
reform-db/models.go 76.47% <0%> (+11.76%) ⬆️
reform-db/models_reform.go 62.02% <0%> (+13.29%) ⬆️
reform-db/cmd_init_mysql.go 32.25% <0%> (+32.25%) ⬆️
reform-db/cmd_init_mssql.go 34.48% <0%> (+34.48%) ⬆️
reform-db/cmd_init_sqlite3.go 72.94% <0%> (+72.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3458d2...934a55f. Read the comment docs.

@AlekSi AlekSi modified the milestones: v1.4.0, v1.5.0 May 31, 2019
@AlekSi AlekSi marked this pull request as draft July 16, 2020 18:31
@AlekSi AlekSi removed the request for review from rumyantseva July 16, 2020 18:31
@AlekSi AlekSi changed the base branch from v1-stable to main July 19, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AlekSi