fix sync pool data race: deep copy (#635)

go-resty · Mar 21, 2023 · b34a3ad · b34a3ad
1 parent f55f417
commit b34a3ad
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/middleware.go b/middleware.go
@@ -169,7 +169,9 @@ func createHTTPRequest(c *Client, r *Request) (err error) {
 			r.RawRequest, err = http.NewRequest(r.Method, r.URL, nil)
 		}
 	} else {
-		r.RawRequest, err = http.NewRequest(r.Method, r.URL, r.bodyBuf)
+		// fix data race: must deep copy.
+		bodyBuf := bytes.NewBuffer(append([]byte{}, r.bodyBuf.Bytes()...))
+		r.RawRequest, err = http.NewRequest(r.Method, r.URL, bodyBuf)
 	}
 
 	if err != nil {