-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix - request: execute user defined middlewares after resty's internal middlewares #355
Conversation
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
=======================================
Coverage 96.18% 96.18%
=======================================
Files 10 10
Lines 1231 1231
=======================================
Hits 1184 1184
Misses 26 26
Partials 21 21
Continue to review full report at Codecov.
|
@jeevatkm it seems travis is stuck, the local tests run fine If you're ok with this changeset post ci, would you mind making a v2.3.1 release so I can update from latest on my project? Thanks in advance |
@lggomez Thank you for your PR. Seems like something is wrong in the travis integration. Will check it. |
Signed-off-by: Jeevanandam M <jeeva@myjeeva.com>
69526df
to
b48bc70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lggomez Thanks for the PR. I'm sorry for the delayed response.
Also, Travis build has been addressed.
Why this merged change not included in V2.6.0 ?I would get raw request in custom middlewares , but the raw request is nill now . |
@jeevatkm Is there any release plan about this change? We can not upgrade to new versions without this. |
@NeoCN Actually this PR was not a fix. That's why it was got reverted. I accidentally merged without realizing it on my bad day. |
This allows middlewares to properly access the RawRequest instance and follow their expected behavior according to OnBeforeRequest: