move udBeforeRequest before beforeRequest again & preReqHooks instead… #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 95.97% 95.98% +0.01%
==========================================
Files 10 10
Lines 1019 1022 +3
==========================================
+ Hits 978 981 +3
Misses 23 23
Partials 18 18
Continue to review full report at Codecov.
|
|
I think it's OK for PR #414 since the main purpose is reverting the breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As #408 reported, many RequestMiddlewares will be invalid when move udBeforeRequest after beforeRequest introduced in v2.4.0, thus all RequestMiddlewares have to change to modify RawReqest directly while not the Request. In the mean time, I noticed that for RequestMiddleware in v2.3.0, there is no way to access or manipulate the RawRequest, but there is another hook: PreRequestHook can meet the requirement, but I think it's better to support a list of PeRequestHook, so I modify the preRequestHook to preRequestHooks.