Allow multipart/form-data in PATCH request #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
==========================================
- Coverage 96.69% 96.39% -0.31%
==========================================
Files 10 10
Lines 1330 1330
==========================================
- Hits 1286 1282 -4
- Misses 26 30 +4
Partials 18 18
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@jeevatkm could you please review this change. |
|
Seems simple enough. We obviously don't have tests around this code. Do you have time to add tests? |
@moorereason Added a simple test as per your suggestion. Please review. |
|
Test result. |
|
@moorereason just checking in to see if you got a chance to review this. |
jeevatkm
approved these changes
Mar 6, 2023
| @@ -128,7 +128,7 @@ func parseRequestHeader(c *Client, r *Request) error { | |||
| func parseRequestBody(c *Client, r *Request) (err error) { | |||
| if isPayloadSupported(r.Method, c.AllowGetMethodPayload) { | |||
| // Handling Multipart | |||
| if r.isMultiPart && !(r.Method == MethodPatch) { | |||
There was a problem hiding this comment.
@sabandi HTTP spec is keep on getting better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.