feat: add nil check to SetResult (#503) #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segevda
reviewed
Feb 24, 2023
| @@ -303,7 +303,9 @@ func (r *Request) SetBody(body interface{}) *Request { | |||
| // Accessing a result value from response instance. | |||
There was a problem hiding this comment.
I wonder if this should be documented here? something like
passing a nil res paramaeter has no effect
There was a problem hiding this comment.
@segevda I will add it later it. Thanks!
Codecov Report
@@ Coverage Diff @@
## master #582 +/- ##
=======================================
Coverage 95.84% 95.85%
=======================================
Files 10 10
Lines 1325 1326 +1
=======================================
+ Hits 1270 1271 +1
Misses 34 34
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #503.
Simply adds a
nilcheck toSetResultto ensure that it can be used fluently. Also adds a simple unit test to ensure that the current panic will not happen any longer.