Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SetLogger() method on Request #584

Merged
merged 1 commit into from Mar 6, 2023

Conversation

muir
Copy link
Contributor

@muir muir commented Sep 30, 2022

Working to integrate resty with xop, I need request-scoped logs. My need would be replicated by anyone else working to integrate resty with span/trace-based logging.

@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #584 (e58935e) into master (840c825) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   95.85%   95.86%   +0.01%     
==========================================
  Files          10       10              
  Lines        1326     1330       +4     
==========================================
+ Hits         1271     1275       +4     
  Misses         34       34              
  Partials       21       21              
Impacted Files Coverage Δ
client.go 97.64% <100.00%> (+<0.01%) ⬆️
middleware.go 91.27% <100.00%> (ø)
request.go 95.32% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeevatkm jeevatkm added this to the v2.8.0 Milestone milestone Mar 6, 2023
@jeevatkm jeevatkm merged commit 64a19d1 into go-resty:master Mar 6, 2023
@muir muir deleted the set-request-logger branch March 6, 2023 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants