Fix race condition during request: Protect pre/post request hooks with RWMutex #597
Conversation
jameshoulahan
changed the title
|
@jameshoulahan Thanks for your compliment and the PR contribution. I agree, if dynamically the middleware is getting added/removed from resty then RWMutex is needed! I just noticed |
|
@jameshoulahan I'm sorry for the late response from my end. |
There was a problem hiding this comment.
@jameshoulahan My bad, I messed up the gofmt while resolving the code conflict with web editor. Could you please revise the PR?
FYI, I have fixed the codecov and PR validation issues.
Codecov Report
@@ Coverage Diff @@
## master #597 +/- ##
==========================================
+ Coverage 95.94% 95.97% +0.02%
==========================================
Files 10 10
Lines 1357 1365 +8
==========================================
+ Hits 1302 1310 +8
Misses 34 34
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Firstly, thanks for the wonderful library! It's an integral part of one of my team's projects and it works beautifully.
In our project, we have one resty client that performs all API requests. It is shared among multiple "users" that each inject their own auth tokens into each request via pre request hooks.
The issue is, if one user is performing requests at the same time as another user is being created (which involves setting up its pre-request hooks), our CI reports a data race.
Given that an API client such as resty is intended to be used in a highly parallel way, potentially by many different places in the code, it makes sense to me that user-modifiable things such as pre- and post-request hooks should be protected from data races. As such, I have added an RWMutex for each user-modifiable hook slice.