Support RawPathParams without escaping #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `RawPathParams` options to `Client` and `Request` objects to support the path parameters with special characters, like `/`, without escaping. Fix go-resty#663
|
Hi @jeevatkm, could you please review this PR? |
|
Hi @jeevatkm, is there a way to get your attention to review this PR? |
3JoB
added a commit
to 3JoB/resty-ilo
that referenced
this pull request
Jul 23, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #664 +/- ##
==========================================
- Coverage 95.73% 95.68% -0.06%
==========================================
Files 11 11
Lines 1571 1598 +27
==========================================
+ Hits 1504 1529 +25
Misses 41 41
- Partials 26 28 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
RawPathParamsoptions toClientandRequestobjects to support the path parameters with special characters, like/, without escaping.Fix #663
Closes #570