Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thumbnail will update in update archive #680

Closed
wants to merge 2 commits into from
Closed

thumbnail will update in update archive #680

wants to merge 2 commits into from

Conversation

Monirzadeh
Copy link
Collaborator

@Monirzadeh Monirzadeh commented Jul 27, 2023 •
edited

This pull request update thumbnail after update archive version. fix #524
now bookmark thumbnail update based on last version of webpage.

@Monirzadeh Monirzadeh marked this pull request as draft July 27, 2023 17:15
@Monirzadeh Monirzadeh marked this pull request as ready for review July 27, 2023 17:30
@fmartingr
Copy link
Member

This is going to get tricky and will require a bigger refactor to make #524 and #634 work together, since on your changes you remove the current data without knowing if the new data will be processed correctly.

@Monirzadeh
Copy link
Collaborator Author

I work on this first and I came to the same point.
I close this and do this in #683.

@Monirzadeh Monirzadeh closed this Jul 29, 2023
@Monirzadeh Monirzadeh mentioned this pull request Jul 29, 2023
Merged
11 tasks
@Monirzadeh Monirzadeh deleted the fix-thumbnail-not-remove-from-fs branch September 17, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The application does not remove the thumbnail file from the FS if it is removed in the original article
2 participants
@Monirzadeh @fmartingr