Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI incorrectly tagging RC releases and disables docker builds on forks #686

Merged
merged 5 commits into from Jul 30, 2023
Merged

Fix CI incorrectly tagging RC releases and disables docker builds on forks #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1c8506
properly tag rc releases
fmartingr Jul 30, 2023
4fef11a
avoid builds on forked prs
fmartingr Jul 30, 2023
fe1484a
Merge branch 'master' into fmartingr/issue677
fmartingr Jul 30, 2023
4eef16a
simplify condition
fmartingr Jul 30, 2023
c2be07d
Merge branch 'master' into fmartingr/issue677
fmartingr Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/_buildx.yml
View file
Open in desktop
Expand Up @@ -26,10 +26,9 @@ jobs:
- name: Prepare master push tags
if: github.event_name == 'push' && github.ref == 'refs/heads/master'
run: |
echo "tag_flags=--tag ${{ github.ref }}" >> $GITHUB_ENV
REPO=ghcr.io/${{ github.repository }}
TAG=$(git describe --tags)
if [ -z "$(git tag --points-at HEAD)" ]
if [ -z "$(git tag --points-at HEAD)" ] || [ "$TAG" == *"rc"* ]
then
TAG2="dev"
else
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/pull_request.yml
View file
Open in desktop
Expand Up @@ -19,4 +19,6 @@ jobs:
uses: ./.github/workflows/_gorelease.yml
call-buildx:
needs: call-gorelease
# only build on pull requests from the same repo for now
if: github.event.pull_request.head.repo.full_name == github.repository
uses: ./.github/workflows/_buildx.yml