Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: styles-check and swag-check monitor just needed directory not project root #747

Merged
merged 3 commits into from Oct 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/styles_check.sh
Expand Up @@ -3,15 +3,15 @@
# This script is used to check if the style.css file is up to date.

# Check if the git tree for CWD is clean
if [ -n "$(git status --porcelain)" ]; then
if [ -n "$(git status internal/view/assets/css --porcelain)" ]; then
echo "❌ git tree is not clean. Please commit all changes before running this script."
exit 1
fi

# Check style.css file
CLEANCSS_OPTS=${CLEANCSS_OPTS} make styles
if [ -n "$(git status --porcelain)" ]; then
if [ -n "$(git status internal/view/assets/css --porcelain)" ]; then
echo "❌ style.css wasn't built from less changes. Please run 'make styles' and commit the changes."
git reset --hard
git checkout -- internal/view/assets/css/
exit 1
fi
10 changes: 5 additions & 5 deletions scripts/swagger_check.sh
Expand Up @@ -10,26 +10,26 @@ if [ "$CURRENT_SWAG_VERSION" != "$REQUIRED_SWAG_VERSION" ]; then
fi

# Check if the git tree for CWD is clean
if [ -n "$(git status --porcelain)" ]; then
if [ -n "$(git status docs/swagger --porcelain)" ]; then
echo "❌ git tree is not clean. Please commit all changes before running this script."
git diff
exit 1
fi

# Check swag comments
make swag-fmt
if [ -n "$(git status --porcelain)" ]; then
if [ -n "$(git status docs/swagger --porcelain)" ]; then
echo "❌ swag comments are not formatted. Please run 'make swag-fmt' and commit the changes."
git diff
git reset --hard
git checkout -- docs/swagger
exit 1
fi

# Check swagger documentation
make swagger
if [ -n "$(git status --porcelain)" ]; then
if [ -n "$(git status docs/swagger --porcelain)" ]; then
echo "❌ swagger documentation not updated, please run 'make swagger' and commit the changes."
git diff
git reset --hard
git checkout -- docs/swagger
exit 1
fi