Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #756

Merged
merged 4 commits into from Oct 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/Contribute.md
Expand Up @@ -45,7 +45,7 @@ Then, run the following command:
make styles
```

The `style.css`/`archive.css` will be updated and changes **needs to be commited** to the repository.
The `style.css`/`archive.css` will be updated and changes **needs to be committed** to the repository.

## Lint the code

Expand Down
2 changes: 1 addition & 1 deletion internal/core/ebook_test.go
Expand Up @@ -101,7 +101,7 @@ func TestGenerateEbook(t *testing.T) {
})
})
t.Run("specific ebook generate case", func(t *testing.T) {
t.Run("unvalid bookmarkId that return Error", func(t *testing.T) {
t.Run("invalid bookmarkId that return Error", func(t *testing.T) {
tempDir := t.TempDir()
mockRequest := core.ProcessRequest{
Bookmark: model.Bookmark{
Expand Down
2 changes: 1 addition & 1 deletion internal/database/database.go
Expand Up @@ -83,7 +83,7 @@ type DB interface {
// DeleteBookmarks removes all record with matching ids from database.
DeleteBookmarks(ctx context.Context, ids ...int) error

// GetBookmark fetchs bookmark based on its ID or URL.
// GetBookmark fetches bookmark based on its ID or URL.
GetBookmark(ctx context.Context, id int, url string) (model.Bookmark, bool, error)

// SaveAccount saves new account in database
Expand Down
4 changes: 2 additions & 2 deletions internal/database/database_test.go
Expand Up @@ -23,7 +23,7 @@ func testDatabase(t *testing.T, dbFactory testDatabaseFactory) {
"testUpdateBookmark": testUpdateBookmark,
"testUpdateBookmarkWithContent": testUpdateBookmarkWithContent,
"testGetBookmark": testGetBookmark,
"testGetBookmarkNotExistant": testGetBookmarkNotExistant,
"testGetBookmarkNotExistent": testGetBookmarkNotExistent,
"testGetBookmarks": testGetBookmarks,
"testGetBookmarksWithSQLCharacters": testGetBookmarksWithSQLCharacters,
"testGetBookmarksCount": testGetBookmarksCount,
Expand Down Expand Up @@ -231,7 +231,7 @@ func testGetBookmark(t *testing.T, db DB) {
assert.Equal(t, book.URL, savedBookmark.URL, "Retrieved bookmark should be the same")
}

func testGetBookmarkNotExistant(t *testing.T, db DB) {
func testGetBookmarkNotExistent(t *testing.T, db DB) {
ctx := context.TODO()

savedBookmark, exists, err := db.GetBookmark(ctx, 1, "")
Expand Down
2 changes: 1 addition & 1 deletion internal/database/mysql.go
Expand Up @@ -500,7 +500,7 @@ func (db *MySQLDatabase) DeleteBookmarks(ctx context.Context, ids ...int) (err e
return nil
}

// GetBookmark fetchs bookmark based on its ID or URL.
// GetBookmark fetches bookmark based on its ID or URL.
// Returns the bookmark and boolean whether it's exist or not.
func (db *MySQLDatabase) GetBookmark(ctx context.Context, id int, url string) (model.Bookmark, bool, error) {
args := []interface{}{id}
Expand Down
2 changes: 1 addition & 1 deletion internal/database/pg.go
Expand Up @@ -509,7 +509,7 @@ func (db *PGDatabase) DeleteBookmarks(ctx context.Context, ids ...int) (err erro
return nil
}

// GetBookmark fetchs bookmark based on its ID or URL.
// GetBookmark fetches bookmark based on its ID or URL.
// Returns the bookmark and boolean whether it's exist or not.
func (db *PGDatabase) GetBookmark(ctx context.Context, id int, url string) (model.Bookmark, bool, error) {
args := []interface{}{id}
Expand Down
2 changes: 1 addition & 1 deletion internal/http/routes/api/v1/bookmarks.go
Expand Up @@ -28,7 +28,7 @@ func (r *BookmarksAPIRoutes) Setup(g *gin.RouterGroup) model.Routes {
func (r *BookmarksAPIRoutes) listHandler(c *gin.Context) {
bookmarks, err := r.deps.Database.GetBookmarks(c, database.GetBookmarksOptions{})
if err != nil {
r.logger.WithError(err).Error("error getting bookmakrs")
r.logger.WithError(err).Error("error getting bookmarks")
response.SendInternalServerError(c)
return
}
Expand Down
2 changes: 1 addition & 1 deletion internal/http/server.go
Expand Up @@ -79,7 +79,7 @@ func (s *HttpServer) Start(_ context.Context) error {
}

func (s *HttpServer) Stop(ctx context.Context) error {
s.logger.WithField("addr", s.http.Addr).Info("stoppping http server")
s.logger.WithField("addr", s.http.Addr).Info("stopping http server")
return s.http.Shutdown(ctx)
}

Expand Down
6 changes: 3 additions & 3 deletions internal/view/assets/less/archive.less
Expand Up @@ -12,7 +12,7 @@

@header-height: 60px;
@screen-sm-max: 600px;
@screen-sm-header-hight: 50px;
@screen-sm-header-height: 50px;

#shiori-archive-header {
top : 0;
Expand Down Expand Up @@ -69,7 +69,7 @@

@media (max-width: @screen-sm-max) {
font-size: 14px;
height : @screen-sm-header-hight;
height : @screen-sm-header-height;

#shiori-logo {
font-size: 1.5em;
Expand All @@ -81,6 +81,6 @@ body.shiori-archive-content {
margin-top: @header-height !important;

@media (max-width: @screen-sm-max) {
margin-top: @screen-sm-header-hight !important;
margin-top: @screen-sm-header-height !important;
}
}
2 changes: 1 addition & 1 deletion internal/webserver/handler-api.go
Expand Up @@ -437,7 +437,7 @@ func (h *Handler) ApiDownloadEbook(w http.ResponseWriter, r *http.Request, ps ht
ContentType: contentType,
}

// if file exist book return avilable file
// if file exist book return available file
strID := strconv.Itoa(book.ID)
ebookPath := fp.Join(request.DataDir, "ebook", strID+".epub")
_, err = os.Stat(ebookPath)
Expand Down
4 changes: 2 additions & 2 deletions internal/webserver/handler-ui.go
Expand Up @@ -278,15 +278,15 @@ func (h *Handler) ServeBookmarkArchive(w http.ResponseWriter, r *http.Request, p
// Gzip it again and send to response writer
gzipWriter := gzip.NewWriter(w)
if _, err := gzipWriter.Write([]byte(outerHTML)); err != nil {
log.Printf("error writting gzip file: %s", err)
log.Printf("error writing gzip file: %s", err)
}
gzipWriter.Flush()
return
}

// Serve content
if _, err := w.Write(content); err != nil {
log.Printf("error writting response: %s", err)
log.Printf("error writing response: %s", err)
}
}

Expand Down
6 changes: 3 additions & 3 deletions internal/webserver/handler.go
Expand Up @@ -25,7 +25,7 @@ type Handler struct {
ArchiveCache *cch.Cache
Log bool

depenencies *config.Dependencies
dependencies *config.Dependencies

templates map[string]*template.Template
}
Expand Down Expand Up @@ -113,7 +113,7 @@ func (h *Handler) validateSession(r *http.Request) error {
return fmt.Errorf("session has been expired")
}

account, err := h.depenencies.Domains.Auth.CheckToken(r.Context(), authParts[1])
account, err := h.dependencies.Domains.Auth.CheckToken(r.Context(), authParts[1])
if err != nil {
return err
}
Expand All @@ -122,7 +122,7 @@ func (h *Handler) validateSession(r *http.Request) error {
return fmt.Errorf("account level is not sufficient")
}

h.depenencies.Log.WithFields(logrus.Fields{
h.dependencies.Log.WithFields(logrus.Fields{
"username": account.Username,
"method": r.Method,
"path": r.URL.Path,
Expand Down
2 changes: 1 addition & 1 deletion internal/webserver/server.go
Expand Up @@ -27,6 +27,6 @@ func GetLegacyHandler(cfg Config, dependencies *config.Dependencies) *Handler {
ArchiveCache: cch.New(time.Minute, 5*time.Minute),
RootPath: cfg.RootPath,
Log: cfg.Log,
depenencies: dependencies,
dependencies: dependencies,
}
}