fix: thumbnail should show last thumbnail in server in any condition #858
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
==========================================
+ Coverage 25.58% 30.76% +5.18%
==========================================
Files 47 60 +13
Lines 5628 4456 -1172
==========================================
- Hits 1440 1371 -69
+ Misses 3989 2863 -1126
- Partials 199 222 +23 ☔ View full report in Codecov by Sentry. |
Monirzadeh
changed the title
| return { | ||
| backgroundImage: `url("${this.imageURL}")`, |
There was a problem hiding this comment.
Can we use some properties from the bookmark instead of a random string? This could break the cache unintentially since each time the query string is going to be different. Can we use ?mtime=<bookmark modified time> ?
There was a problem hiding this comment.
will modified time update if just thumbnail update in article? i am sure that i am not update that in #683 so if that will handle in other part of code automatically we can use modified time too.
i don't find when modified time update in code. do you know where is that or i can send request to update that while thumbnail update
if just thumbnail will update but modify time not update automatically than it will get in trouble in that situation.
There was a problem hiding this comment.
I always assumed Bookmark.ModifiedTime was the datetime when the bookmark was last modified (attributes/archive/readable/ebook) modified, it seems that is not the case. Let me think and get back to you.
There was a problem hiding this comment.
I ended up not updating you here.
My idea is:
- Refactor the migration system (feat: new migration system #876)
- Add a
createdcolumn to the bookmarks with the time the bookmark was first created and prefill it with the currentmodifiedfor existing bookmarks. - Update
modifiedevery time the bookmark is updated (either the data, content, archive, etc).
Then, we can use the modified as query parameter for the thumbnail.
There was a problem hiding this comment.
it is better so i will wait until #876 finish than start working on that.
but an small point: i like the idea of keep first created time and modified time separately if exist instead of prefill (you can look at #848)
so created and modified be better to separated. having created time help me to track my activity in long term so i think having that can be helpful.
@fmartingr and @GreenBlast what do you think?
There was a problem hiding this comment.
can you mention the function that currently update modified time? i can't find that (to use when just thumbnail update).
thumbnail not update in browser sometimes.
bun.lockbupdate withmake styleso i just push that too.Closes #857
Depends on #896