custom projections, fixed sys.Lam0 and sys.Phi0 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i0 to be in radians, as the code appears to expect, not degrees.
…y divide by 0s when unit are specified
ARolek
reviewed
Jul 22, 2021
| // CustomProjection provides write-only access to the internal projection list | ||
| // so that projections may be added without having to modify the library code. | ||
| func CustomProjection(code EPSGCode, str string) { | ||
| projStrings[code] = str |
There was a problem hiding this comment.
I few ideas on this method:
- Implement a mutex since you're modifying a map
- Perform a check that the code is not already registered. I'm not sure if this should overwrite a code that already exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CustomProjection() to Convert.go to allow custom projection strings to be loaded in without having to modify the package.
More importantly, while trying to use this package with EPSG3005, which uses the Albers Equal Area projection, it was discovered that numerous problems with that projection were being caused by sys.Lam0 and sys.Phi0 being in degrees, whereas anywhere those values are referenced in the code, they are referenced as radians.
Also changed default value of sys.FromMeter to 1.0, as the go zero value of 0.0 was causing divide by 0 errors when units were specified in the proj string.