-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remote): support include git remote #1652
base: main
Are you sure you want to change the base?
Conversation
I've tested it and a friend also tested it. I am open to gather feedback on it :) |
@vmaerten Thanks for working on this! This is a very popular request. I will definitely give this a go in the next couple of days. Finally some nice weather in the UK, so I'll be out enjoying the sun as much as possible this weekend! 🌞 It might be worth putting a message on the remote experiment issue so that people who are subscribed over there can try it too. I have updated the OP there to link back here. |
I really enjoy working on Task. Let me know if you have questions regarding my implementation Good idea! I've just done it 🙂 |
@blackjid 's comment :
First of all, thanks for the feedback. Following your propostions, I like the one with the query param representing the filename. In the other hand, if the community already knows the "terraform" format, it could be good to adopt it. Let's discuss with @pd93 and @andreynering |
I've work on add the support of Git in the remote experimentation.
I've used the go-git package, which is Git implementation in pure go.
I've also used git-urls to help me to parse all URLs.
Some informations :
I'll work next on perf optimisation. I've in mind to mutualise git clone to avoid cloning multiple times the same repo.
I've added tests. I'll add test of node_http in another PR.
EDIT : The link with to the preview