chore(nolint): nolint should have no leading spaces

.golangci.yml

@@ -49,7 +49,6 @@ linters-settings:
 
   # https://github.com/golangci/golangci-lint/blob/master/pkg/golinters/nolintlint
   nolintlint:
-    allow-leading-space: true     # allow non-"machine-readable" format (ie. with leading space) 
     allow-unused: false           # allow nolint directives that don't address a linting issue
     require-explanation: true     # require an explanation for nolint directives
     require-specific: true        # require nolint directives to be specific about which linter is being skipped

constants/badge.go

@@ -5,7 +5,8 @@
 package constants
 
 // Constants for build badges.
-// nolint:godot // due to providing pretty printed svgs
+//
+//nolint:godot // due to providing pretty printed svgs
 const (
 	// Badge for unknown state
 	// <svg xmlns="http://www.w3.org/2000/svg" width="92" height="20">

database/build.go

@@ -94,7 +94,7 @@ func (b *Build) Crop() *Build {
 // value for the field, the valid flag is set to
 // false causing it to be NULL in the database.
 //
-// nolint: gocyclo // ignore cyclomatic complexity due to number of fields
+//nolint:gocyclo // ignore cyclomatic complexity due to number of fields
 func (b *Build) Nullify() *Build {
 	if b == nil {
 		return nil

database/build_test.go

@@ -246,7 +246,7 @@ func randomString(n int) string {
 
 	b := make([]rune, n)
 	for i := range b {
-		// nolint:gosec // accepting weak RNG for test
+		//nolint:gosec // accepting weak RNG for test
 		b[i] = letter[rand.Intn(len(letter))]
 	}
 

library/build.go

@@ -55,7 +55,7 @@ type Build struct {
 func (b *Build) Duration() string {
 	// check if the build doesn't have a started timestamp
 	if b.GetStarted() == 0 {
-		// nolint: goconst // ignore making a constant
+		//nolint: goconst // ignore making a constant
 		return "..."
 	}
 
@@ -1006,7 +1006,8 @@ func (b *Build) SetDistribution(v string) {
 }
 
 // String implements the Stringer interface for the Build type.
-// nolint:dupl // this is duplicated in the test
+//
+//nolint:dupl // this is duplicated in the test
 func (b *Build) String() string {
 	return fmt.Sprintf(`{
   Author: %s,

library/build_queue.go

@@ -2,7 +2,7 @@
 //
 // Use of this source code is governed by the LICENSE file in this repository.
 
-// nolint: dupl // ignore false positive with template.go
+//nolint:dupl // ignore false positive with template.go
 package library
 
 import "fmt"

library/template.go

@@ -2,7 +2,7 @@
 //
 // Use of this source code is governed by the LICENSE file in this repository.
 
-// nolint: dupl // ignore false positive with build_queue.go
+//nolint:dupl // ignore false positive with build_queue.go
 package library
 
 import (

pipeline/container.go

@@ -377,7 +377,7 @@ func dnsSafeRandomString(n int) string {
 
 	b := make([]rune, n)
 	for i := range b {
-		// nolint:gosec // this is not about security. Just a random string.
+		//nolint:gosec // this is not about security. Just a random string.
 		b[i] = letter[rand.Intn(len(letter))]
 	}
 

pipeline/ruleset.go

@@ -122,7 +122,8 @@ func (r *Rules) Empty() bool {
 // ruletypes from the rules match the provided ruledata. For
 // both operators, when none of the ruletypes from the rules
 // match the provided ruledata, the function returns false.
-// nolint:gocyclo // accepting complexity in this case
+//
+//nolint:gocyclo // accepting complexity in this case
 func (r *Rules) Match(from *RuleData, matcher, op string) bool {
 	// set defaults
 	status := true

yaml/ruleset.go

@@ -62,10 +62,10 @@ func (r *Ruleset) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	})
 
 	// attempt to unmarshal simple ruleset
-	// nolint:errcheck // intentionally not handling error
+	//nolint:errcheck // intentionally not handling error
 	unmarshal(simple)
 	// attempt to unmarshal advanced ruleset
-	// nolint:errcheck // intentionally not handling error
+	//nolint:errcheck // intentionally not handling error
 	unmarshal(advanced)
 
 	// set ruleset `unless` to advanced `unless` rules

yaml/service.go

@@ -58,7 +58,8 @@ func (s *ServiceSlice) ToPipeline() *pipeline.ContainerSlice {
 }
 
 // UnmarshalYAML implements the Unmarshaler interface for the ServiceSlice type.
-// nolint:dupl // accepting duplicative code that exists in step.go as well
+//
+//nolint:dupl // accepting duplicative code that exists in step.go as well
 func (s *ServiceSlice) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	// service slice we try unmarshalling to
 	serviceSlice := new([]*Service)

yaml/step.go

@@ -69,7 +69,8 @@ func (s *StepSlice) ToPipeline() *pipeline.ContainerSlice {
 }
 
 // UnmarshalYAML implements the Unmarshaler interface for the StepSlice type.
-// nolint:dupl // accepting duplicative code that exits in service.go as well
+//
+//nolint:dupl // accepting duplicative code that exits in service.go as well
 func (s *StepSlice) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	// step slice we try unmarshalling to
 	stepSlice := new([]*Step)