fix(k8s/build/sanitize): implement similar line length and lowercase logic as containers for build #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…logic as containers for build
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 97.08% 96.93% -0.16%
==========================================
Files 57 57
Lines 6288 6301 +13
==========================================
+ Hits 6105 6108 +3
- Misses 134 143 +9
- Partials 49 50 +1
|
wass3r
approved these changes
Sep 15, 2022
JordanSussman
approved these changes
Sep 16, 2022
plyr4
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes go-vela/community#679
https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#dns-label-names
Users run into trouble if their org or repo have uppercase letters, or the combination of the two results in a string longer than 63 characters. Fix was already in place for container names, but not pods.