Internal: Ensure Behat tests abort if updates fail with requirements errors #3690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Drush requires the -y flag to run in automated environments because it prompts with the list of available updates. However it also does an update requirements check which gets skipped by the same -y option.
This means that our update path in the CI doesn't fail if there are requirements errors (even though it should, because it causes errors later in tests that are hard to debug) and our tests against fixture dumps for specific update scenarios also don't fail.
Solution
Until Drush provides a better solution in
drush-ops/drush#5806. We manually go through the update output and errors if the key sentence for requirements errors is spotted.
Issue tracker
Internal no issue
Theme issue tracker
[Required if applicable] Paste a link to the drupal.org theme issue queue item, either from socialbase or socialblue. If any other issue trackers were used, include links to those too.
How to test
Definition of done
Before merge
After merge
Screenshots
Release notes
Change Record
Translations