-
-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
web/admin: rework initial wizard pages and add grid layout #9668
Conversation
✅ Deploy Preview for authentik-docs canceled.
|
✅ Deploy Preview for authentik-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9668 +/- ##
=======================================
Coverage 92.63% 92.64%
=======================================
Files 709 710 +1
Lines 34659 34706 +47
=======================================
+ Hits 32105 32152 +47
Misses 2554 2554
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
authentik PR Installation instructions Instructions for docker-composeAdd the following block to your AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e76758ae0339a4cc8b6bb2f341fa03862e8de992
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s For arm64, use these values: AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e76758ae0339a4cc8b6bb2f341fa03862e8de992-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s Afterwards, run the upgrade commands from the latest release notes. Instructions for KubernetesAdd the following block to your authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-e76758ae0339a4cc8b6bb2f341fa03862e8de992 For arm64, use these values: authentik:
outposts:
container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
repository: ghcr.io/goauthentik/dev-server
tag: gh-ghcr.io/goauthentik/dev-server:gh-e76758ae0339a4cc8b6bb2f341fa03862e8de992-arm64 Afterwards, run the upgrade commands from the latest release notes. |
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 25.1%, saving 24.92 KB.
155 images did not require optimisation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of these changes, especially the abstraction of the "choose your type", although you're still thinking in an OO way that "routes around" some of the DOM-ness (and at other times is mind-bogglingly into wild things like filling all the slots and then providing only one of them for viewing at any time, which confuses the heck out of the debugger, which I think is nifty).
Anyway, it's nice to see a whole frackload of copy/paste disappear into a simple component.
import PFBase from "@patternfly/patternfly/patternfly-base.css"; | ||
|
||
import { SourcesApi, TypeCreate } from "@goauthentik/api"; | ||
|
||
@customElement("ak-source-wizard-initial") | ||
export class InitialSourceWizardPage extends WizardPage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's always nice to see a change that just makes a whole bunch of code disappear. :-)
@@ -2,7 +2,6 @@ | |||
"extends": "./tsconfig.base.json", | |||
"compilerOptions": { | |||
"paths": { | |||
"@goauthentik/authentik/*": ["src/*"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
we should probably replace all icons with coloured ones so we don't need to invert them...I guess Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
6cb4caa
to
30e142d
Compare
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like a lot of the changes in the UI! Thanks!
|
||
export const providerRendererList = new Map<string, ProviderRenderer>( | ||
_providerModelsTable.map(([modelName, _0, _1, renderer]) => [modelName, renderer]), | ||
providerModelsList.map((tc) => [tc.formName, tc.renderer]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad this wasn't too confusing. If data is uniform, I like tuples, and I like annotating them.
* main: (36 commits) ci: use container registry for container build cache (#9809) core: bump lxml from 5.2.1 to 5.2.2 (#9717) web: bump mermaid from 10.9.0 to 10.9.1 in /web (#9734) core: bump scim2-filter-parser from 0.5.0 to 0.5.1 (#9730) web: bump core-js from 3.37.0 to 3.37.1 in /web (#9733) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9729) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9802) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9803) core: bump sentry-sdk from 2.2.0 to 2.2.1 (#9807) web: bump the storybook group in /web with 7 updates (#9804) web: bump glob from 10.3.15 to 10.3.16 in /web (#9805) root: docker-compose: remove version top level element (#9631) core, web: update translations (#9790) web: bump API Client version (#9801) web/admin: rework initial wizard pages and add grid layout (#9668) website/integrations: discord: fix typo (#9800) website/integration/netbox: fix group custom pipeline example (#9738) root: add primary-replica db router (#9479) website/integrations: add three more policy-expressions to discord-docs (#5760) website/integrations: netbox: add missing scope configuration (#9491) ...
Signed-off-by: Jens Langhammer jens@goauthentik.io<!--
👋 Hi there! Welcome.
Please check the Contributing guidelines: https://goauthentik.io/developer-docs/#how-can-i-contribute
-->
Details
REPLACE ME
Checklist
ak test authentik/
)make lint-fix
)If an API change has been made
make gen-build
)If changes to the frontend have been made
make web
)If applicable
make website
)