fix(authentik): add option to set serviceaccount #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wrenix
force-pushed
the
feat/serviceAccount
branch
from
02601ca
to
9c8565d
Compare
rissson
requested changes
Mar 14, 2024
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| apiVersion: v2 | |||
| version: 2024.2.2 | |||
There was a problem hiding this comment.
I'll let @BeryJu comment on whether we should increase the chart version.
wrenix
force-pushed
the
feat/serviceAccount
branch
from
d08e3d4
to
8940664
Compare
BeryJu
reviewed
Mar 14, 2024
There was a problem hiding this comment.
I think for the server container we could just not mount a service account at all since it doesn't need one. Although I suppose that would only change the defaults as there might still be usecases where someone might want to mount a service account themselves
|
That is not BSI conform to use default serviceAccount, take a look in: if you prefer to stop using the mount of the serviceaccount, it will break additional feature which user of this helm-chart could needed (e.g. #146). |
Co-authored-by: Marc 'risson' Schmitt <marc.schmitt@risson.space> Signed-off-by: WrenIX <133280015+wrenix@users.noreply.github.com>
wrenix
force-pushed
the
feat/serviceAccount
branch
from
8940664
to
6d30ff4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I like to follow security guide lines, which say nobody should use the "default" serviceAccount of an namespace ...
so i like to create my own serviceAccount and assign it with this helm-chart.
PS: maybe it is also needed for #146