fix: decode struct with pointer must be nil (#473)

goccy · Oct 19, 2023 · df897ae · df897ae
1 parent 3d5ab28
commit df897ae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/decode_test.go b/decode_test.go
@@ -197,6 +197,13 @@ func Test_Decoder(t *testing.T) {
 			assertEq(t, "interface{}", v.F, nil)
 			assertEq(t, "nilfunc", true, v.G == nil)
 		})
+		t.Run("struct.pointer must be nil", func(t *testing.T) {
+			var v struct {
+				A *int
+			}
+			json.Unmarshal([]byte(`{"a": "alpha"}`), &v)
+			assertEq(t, "struct.A", v.A, (*int)(nil))
+		})
 	})
 	t.Run("interface", func(t *testing.T) {
 		t.Run("number", func(t *testing.T) {

diff --git a/internal/decoder/ptr.go b/internal/decoder/ptr.go
@@ -85,6 +85,7 @@ func (d *ptrDecoder) Decode(ctx *RuntimeContext, cursor, depth int64, p unsafe.P
 	}
 	c, err := d.dec.Decode(ctx, cursor, depth, newptr)
 	if err != nil {
+		*(*unsafe.Pointer)(p) = nil
 		return 0, err
 	}
 	cursor = c