Resolve 424: Set (*Stream).bufSize equal to size of (*Stream).buf when it resized #428
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
==========================================
+ Coverage 76.95% 76.99% +0.03%
==========================================
Files 55 55
Lines 18806 18807 +1
==========================================
+ Hits 14472 14480 +8
+ Misses 3695 3690 -5
+ Partials 639 637 -2 |
| @@ -270,6 +270,7 @@ func stringBytes(s *Stream) ([]byte, error) { | |||
| r, size := utf8.DecodeRune(s.buf[cursor:]) | |||
| if r == utf8.RuneError { | |||
| s.buf = append(append(append([]byte{}, s.buf[:cursor]...), runeErrBytes...), s.buf[cursor+1:]...) | |||
| s.bufSize = int64(len(s.buf)) | |||
There was a problem hiding this comment.
@vadiminshakov I would like some more explanation as to why the bufSize needs to be changed at this place
There was a problem hiding this comment.
We get panic here https://github.com/goccy/go-json/blob/master/internal/decoder/stream.go#L201
Panic occurs because the cursor is pointing out of bounds s.buf.
s.buf slice boundaries are set here: https://github.com/goccy/go-json/blob/master/internal/decoder/stream.go#L195)
But these boundaries do not match where the cursor is pointing. My change makes it so that the cursor does not go beyond the buffer bounds (on s.buf resize we change bufSize accordingly).
Resolve issue 464