Add license for string processing #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
+ Coverage 76.75% 76.76% +0.01%
==========================================
Files 55 55
Lines 18921 18921
==========================================
+ Hits 14522 14525 +3
+ Misses 3763 3761 -2
+ Partials 636 635 -1 |
stacybird
reviewed
Feb 29, 2024
| @@ -30,7 +30,7 @@ golangci-lint: | $(BIN_DIR) | |||
| GOLANGCI_LINT_TMP_DIR=$$(mktemp -d); \ | |||
| cd $$GOLANGCI_LINT_TMP_DIR; \ | |||
| go mod init tmp; \ | |||
| GOBIN=$(BIN_DIR) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.48.0; \ | |||
| GOBIN=$(BIN_DIR) go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.2; \ | |||
There was a problem hiding this comment.
@goccy When will this be in a release? There is a divide here between lint in 1.19 and previous and 1.20 and forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #475