Add version2 of function/aggregate metadata #1590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
medasx
approved these changes
Apr 12, 2022
There were the following issues with handling of aggregates: - compileMetadata panicked if final_func was null. final_func is optional[1], so null is perfectly valid value. - The AggregateMetadata FinalFunc field could not store nil, so it is not possible to represent the null. - Functions and aggregates are not uniquely identified just by name. There could be two functions with the same name, but different argument types. I'm adding a new version of function and aggregate metadata to fix those shortcomings. For backward compatibility, I leave the V1 metadata filled-in where possible. Fixes gocql#1587 [1] https://cassandra.apache.org/doc/latest/cassandra/cql/functions.html#user-defined-aggregates-functions
martin-sucha
force-pushed
the
aggregates-v2
branch
from
2a45da8
to
cc1af80
Compare
|
no we have semver can we just replace the broken api and bump the major version |
|
That is true. We could bump the major version. If we do, we should also get rid of other deprecated APIs. Also, question is what gocql/v2 will mean in terms of the ecosystem, e.g. for updating gocqlx. cc @mmatczuk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were the following issues with handling of aggregates:
final_func is optional[1], so null is perfectly valid value.
so it is not possible to represent the null.
There could be two functions with the same name, but different
argument types.
I'm adding a new version of function and aggregate metadata to fix
those shortcomings. For backward compatibility, I leave the V1
metadata filled-in where possible.
Fixes #1587
[1] https://cassandra.apache.org/doc/latest/cassandra/cql/functions.html#user-defined-aggregates-functions