Update test to pass w/ pierrec/lz4 4.1.14 #1662
Conversation
lz4/go.mod
Outdated
| @@ -3,6 +3,6 @@ module github.com/gocql/gocql/lz4 | |||
| go 1.16 | |||
|
|
|||
| require ( | |||
| github.com/pierrec/lz4/v4 v4.1.8 | |||
| github.com/pierrec/lz4/v4 v4.1.14 | |||
There was a problem hiding this comment.
Did you intend to bump the version in this commit? The commit message only mentions updating the test, not the dependency.
We could upgrade the version (even to 4.1.17) since there seem to be only bugfixes in pierrec/lz4@v4.1.8...v4.1.17, but in that case the commit message should probably say something like
Upgrade pierrec/lz4 to 4.1.17
There are bug fixes in the new version.
The `lz4.UncompressBlock(...)` was changed in 4.1.14 to be compatible
with the asm decoders.
As a result, TestLZ4Compressor now failed since this version.
See: https://github.com/pierrec/lz4/issues/160 & https://github.com/pierrec/lz4/issues/163
Please either update the commit message or remove the version bump.
There was a problem hiding this comment.
Please either update the commit message or remove the version bump.
Done
There was a problem hiding this comment.
Thanks! Now I see that the commit message mentions v4.1.17, but there is still v4.1.14 in go.mod. Please change the version in go.mod to 4.1.17 so that it matches the commit message.
There was a problem hiding this comment.
Thanks! Now I see that the commit message mentions v4.1.17, but there is still v4.1.14 in go.mod. Please change the version in go.mod to 4.1.17 so that it matches the commit message.
Gah, sorry; I got some wires crossed there it seems.
There are bug fixes in the new version. The `lz4.UncompressBlock(...)` was changed in 4.1.14 to be compatible with the asm decoders. As a result, `TestLZ4Compressor` was updated to pass under the new semantics (see: pierrec/lz4#160 and pierrec/lz4#163)
The
lz4.UncompressBlock(...)was changed in 4.1.14 to be compatible with the asm decoders. As a result, this test will now fail.See: pierrec/lz4#160 & pierrec/lz4#163